Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nginx apt-key is deprecated failure #1518

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix Nginx apt-key is deprecated failure #1518

merged 1 commit into from
May 30, 2024

Conversation

Twansparant
Copy link
Contributor

🐛 Fix NginxDB apt-key is deprecated failure

  • Use apt_repository
  • Use apt_key module

@swalkinshaw swalkinshaw merged commit a085156 into roots:master May 30, 2024
2 checks passed
@paulbrzeski
Copy link
Contributor

Hey Trellis devs, I think I've spotted a race conditions issue with this fix.

I just tried to reprovision a box using a version of Trellis containing the fix but it still failed due on apt update due to deprecated nginx keys. Ran the fix manually on the box and it worked, i.e. wget https://nginx.org/keys/nginx_signing.key -O - | sudo apt-key add -

Checked out how server.yml is structured. The [common] task runs first and that contains the apt update. If anyone has invalid keys blocking the update then they won't get up to the [nginx] task to do the key update. Checked the issues list and it's not been rerecorded so I'm just gonna logging it here

Not sure what the fix would be... Maybe if there's an option to add an error handling step to Ansible.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants